New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use diffBuffer, provided from hermione #483

Merged

KuznetsovRoman merged 2 commits into master from HERMIONE-1088.html-reporter_diff_buffer

Aug 21, 2023

Member

KuznetsovRoman commented Aug 7, 2023

Что сделано

Добавил возможность не считать дифф, если он уже посчитан и передан от hermione
Оставил существующую логику для обеспечения обратной совместимости
Обновил looks-same, чтобы ускорить расчет диффа на новых версиях html-reporter со старыми версиями hermione

xrsd reviewed

View reviewed changes

test/unit/lib/test-adapter.js Outdated Show resolved Hide resolved

xrsd approved these changes

View reviewed changes


          perf: use diffBuffer, provided from hermione

ad5f99e

KuznetsovRoman force-pushed the HERMIONE-1088.html-reporter_diff_buffer branch from 0bbf0e0 to ad5f99e Compare

August 21, 2023 12:18


          fix: property size of undefined while accepting screenshot

cab7ecb

KuznetsovRoman merged commit 76b8fe3 into master

5 checks passed

KuznetsovRoman deleted the HERMIONE-1088.html-reporter_diff_buffer branch

August 21, 2023 14:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet