Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-write some files to typescript #487

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Aug 10, 2023

What's done?

  • re-written a few files to typescript as a preparation step for playwright support
  • fixed mocha tests running: tests in jsx files were not being launched before

Why?

  • to introduce strong types and be able to write new code in TS

⚠️ Notes

  • package-lock.json was reverted in the last commit to not clutter PR diff and that's why checks are failing
  • every commit is atomic, meaning all checks pass on every commit but the last one
  • might be a good idea to review each commit separately: in the final diff some moved files appear as completely removed/added, but when viewing commits separately you can see what's been truly changed

@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1003 branch from d7654fb to 97bb2d9 Compare August 10, 2023 07:07
@shadowusr shadowusr changed the title Users/shadowusr/hermione 1003 chore: re-write some files to typescript Aug 10, 2023
lib/constants/test-statuses.ts Show resolved Hide resolved
lib/test-adapter.ts Outdated Show resolved Hide resolved
test/unit/hermione.js Show resolved Hide resolved
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1003 branch from 97bb2d9 to d132134 Compare August 11, 2023 09:50
@shadowusr shadowusr merged commit 9b58bbb into master Aug 11, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants