chore: re-write some files to typescript - part 2 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowusr
changed the title
shadowusr
commented
Aug 17, 2023
shadowusr
commented
Aug 17, 2023
|
|
||
| export type AssertViewResult = ImageDiffError; | ||
|
|
||
| export interface TestResult { |
There was a problem hiding this comment.
В этом файле многие типы вручную описаны, хотя похожие типы есть в hermione. Не делал импортов специально, чтобы не добавлять связности между пакетами. В будущем можно будет подрефакторить этот момент и сделать, например, адаптер
shadowusr
commented
Aug 17, 2023
| @@ -126,7 +163,7 @@ module.exports = class TestAdapter { | |||
| return {path: expectedPath, reused: false}; | |||
| } | |||
|
|
|||
| getImagesFor(status, stateName) { | |||
| getImagesFor(status: TestStatus, stateName?: string): ImageInfo | undefined { | |||
There was a problem hiding this comment.
В этом методе условия стали чуть строже, а вместо {} возвращается undefined
There was a problem hiding this comment.
Почему undefined а не void?
shadowusr
force-pushed
the
users/shadowusr/HERMIONE-1003.typescript-part-2
branch
from
d7efc5b
to
e438e5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done?
Why?