chore: re-write some files to typescript - part 3 #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowusr
commented
Aug 22, 2023
| @@ -2,6 +2,7 @@ | |||
| /* eslint-env browser */ | |||
|
|
|||
| const {isEmpty} = require('lodash'); | |||
| /** @type Record<string, (...args: unknown[]) => unknown> */ | |||
There was a problem hiding this comment.
Пришлось добавить временно jsdoc, чтобы не ругался компилятор tsc
shadowusr
commented
Aug 22, 2023
| addSkipped(result) { | ||
| const formattedResult = this.format(result); | ||
| addSkipped(result: TestResult | TestAdapter): TestAdapter { | ||
| const formattedResult = this.format(result, SKIPPED); |
There was a problem hiding this comment.
Тут показалось логичным всегда передавать статус, но обсуждаемо.
Конкретно в этом месте есть разница в поведении в runtime. Ранее передавался undefined, следовательно условие в test-adapter:
if (utils.shouldUpdateAttempt(status)) { // ![SKIPPED, UPDATED, RUNNING, IDLE].includes(status);
testsAttempts.set(this._testId, _.isUndefined(testsAttempts.get(this._testId)) ? 0 : testsAttempts.get(this._testId) as number + 1);
}
Выполнялось. Стали передавать SKIPPED — оно выполняться перестанет.
shadowusr
commented
Aug 22, 2023
| @@ -91,6 +91,8 @@ export class TestAdapter { | |||
| this._attempt = testsAttempts.get(this._testId) || 0; | |||
| } | |||
|
|
|||
| image?: boolean; | |||
There was a problem hiding this comment.
Пришлось добавить из-за строки в static report builder:
formattedResult.image = hasImage(formattedResult);
shadowusr
force-pushed
the
users/shadowusr/HERMIONE-1003.typescript-part-3
branch
from
198c456
to
6d04d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done?
Why?