Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get rid of tight coupling with hermione and move image processing logic out of test-adapter #491

Merged
merged 5 commits into from
Sep 1, 2023
Merged

refactor: get rid of tight coupling with hermione and move image processing logic out of test-adapter #491

merged 5 commits into from
Sep 1, 2023

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Aug 29, 2023 •
edited
Loading

What's done?

  • Got rid of passing hermione instance in most classes
  • Refactored test-adapter by moving image processing logic to a separate class

Why?

  • Opens a road to playwright support
  • Test adapter became a "catch-all" class violating single responsibility principle and that needed to be fixed. That was especially an issue when saving images in playwright.

@shadowusr shadowusr changed the title Users/shadowusr/hermione 1003.refactoring part 1 refactor: get rid of tight coupling with hermione and move image processing logic out of test-adapter Aug 29, 2023
shadowusr
shadowusr commented Aug 29, 2023
View reviewed changes
lib/test-adapter.ts Outdated Show resolved Hide resolved
DudaGod
DudaGod approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 (только тесты нужно пофиксить)

lib/report-builder/static.ts Outdated Show resolved Hide resolved
test/unit/lib/sqlite-adapter.js Outdated Show resolved Hide resolved
lib/common-utils.ts Outdated Show resolved Hide resolved
lib/common-utils.ts Show resolved Hide resolved
lib/image-handler.ts Outdated Show resolved Hide resolved
lib/image-handler.ts Show resolved Hide resolved
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1003.refactoring-part-1 branch from 380405a to 75cb2a0 Compare August 31, 2023 15:12
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1003.refactoring-part-1 branch from 75cb2a0 to bccefe2 Compare August 31, 2023 15:18
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1003.refactoring-part-1 branch from bccefe2 to 7a01864 Compare September 1, 2023 11:12
@shadowusr shadowusr merged commit 469387f into master Sep 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DudaGod DudaGod DudaGod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowusr @DudaGod