fix: pwt static image accepter #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Aug 28, 2024
Comment on lines
+113
to
+115
| const trueResultStatus = isImageError(result.error) && finalStatus === ERROR ? FAIL : finalStatus; | ||
|
|
||
| if (isAssertViewError(result.error) && trueResultStatus !== result.status) { | ||
| if (isImageError(result.error) && trueResultStatus !== result.status) { |
There was a problem hiding this comment.
In Testplane, we have a contract: if test result has image errors, test result has "AssertViewError", and images can have either ImageDiffError or NoRefImageError.
In Playwright adapter, though, we can have ImageDiffError or NoRefImageError as result.error. Looks like we could encounter other issues because of that.
KuznetsovRoman
commented
Aug 28, 2024
| @@ -34,6 +34,8 @@ export type PwtImageDiffError = ExtendedError<{snapshotName: string, diffCluster | |||
|
|
|||
| export type PwtNoRefImageError = ExtendedError<{snapshotName: string}>; | |||
|
|
|||
| export type PlaywrightImageFile = ImageFile & { relativePath: string }; | |||
There was a problem hiding this comment.
I don't want to pollute ImageFile type, which is used in Testplane and generally has no guaranteed "relativePath" property
sipayRT
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.