fix: do not activate extension if config is not found #12
Conversation
DudaGod
force-pushed
the
TESTPLANE-265.do_not_activate_by_default
branch
from
a94a9ad
to
6526909
Compare
| @@ -4,7 +4,7 @@ node_modules | |||
| .DS_Store | |||
| vscode.d.ts | |||
| .eslintcache | |||
| samples/**/.* | |||
| samples/**/.testplane | |||
There was a problem hiding this comment.
In order to not ignore .vscode folder
| @@ -38,6 +38,16 @@ | |||
| "name": "Testplane" | |||
| } | |||
| ] | |||
| }, | |||
| "configuration": { | |||
There was a problem hiding this comment.
The options described in this section are displayed in settings interface
| "test-e2e:basic": "wdio run ./tests/e2e/basic/wdio.conf.ts", | ||
| "test-e2e:settings-view": "wdio run ./tests/e2e/settings-view/wdio.conf.ts", | ||
| "test-e2e:vscode-settings": "wdio run ./tests/e2e/vscode-settings/wdio.conf.ts", | ||
| "test-e2e:empty": "wdio run ./tests/e2e/empty/wdio.conf.ts", |
There was a problem hiding this comment.
Here I test that extension do nothing on open testing bar
| const workerPath = resolve(__dirname, "worker.js"); | ||
| const configPaths = await vscode.workspace.findFiles(CONFIG_GLOB, CONFIG_GLOB_EXCLUDE); |
There was a problem hiding this comment.
Now config read only in one place and only if user not specify configPath in .vscode/settings.json
| "noUnusedParameters": true, | ||
| "noFallthroughCasesInSwitch": true | ||
| }, | ||
| "extends": "../tsconfig.common.json", |
There was a problem hiding this comment.
just refactor the same tsconfig files
| await fs.mkdir(screenshotDir, { recursive: true }); | ||
| await browser.saveScreenshot(path.join(screenshotDir, `${test.parent} - ${test.title}.png`)); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
just refactor the same wdio configs
| const [firstSection] = await sidebar.getSections(); | ||
| const items = await firstSection.getVisibleItems(); | ||
|
|
||
| expect(items).toHaveLength(0); |
There was a problem hiding this comment.
Here I check that nothing render inside Test explorer. It means that Reading Testplane tests is removed
| expect(items).toHaveLength(0); | ||
|
|
||
| const webview = await vscodePO.getWebviewByTitle("Testplane"); | ||
| expect(webview.elem).toBeDisplayed(); |
There was a problem hiding this comment.
Check that Testplane webview displayed.
DudaGod
force-pushed
the
TESTPLANE-265.do_not_activate_by_default
branch
2 times, most recently
from
28dc0a2
to
ebc6075
Compare
DudaGod
force-pushed
the
TESTPLANE-265.do_not_activate_by_default
branch
2 times, most recently
from
0149751
to
fd81f6f
Compare
DudaGod
force-pushed
the
TESTPLANE-265.do_not_activate_by_default
branch
from
fd81f6f
to
22fab0a
Compare
No description provided.