-
-
Notifications
You must be signed in to change notification settings - Fork 246
Feature/json io #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/json io #1013
Conversation
- Add JSON I/O module with schema definitions - Implement surface points loading functionality - Add comprehensive test suite for surface points I/O - Create tutorial demonstrating JSON I/O usage
- Add orientation schema and loading methods - Implement orientation data validation and polarity handling - Add comprehensive test suite for orientation loading - Fix polarity handling in test data
- Create tutorial demonstrating JSON I/O with horizontal stratigraphic model - Add sample JSON file with model data - Include surface points and orientations for two horizontal layers
…id_to_name mapping from surface IDs to names - Update surface points and orientations loading to use actual surface names - Fix issue with surface names not matching between structural frame and series
…odel computation - Update surface points and orientations to match original CSV files - Add model computation step before plotting - Fix plot display using Agg backend
…oading and saving models
…s work, some problems with fault relations still remaining.
…ns requried; standard stack created by default based on point/ orientation ids.
…lization - Fixed series mapping, fault orientation, and plotting
…r visualization, fix surface points plotting, add colorbar and labels
…ervation, fixed color assignment to structural elements
…r assertions in test_multiple_series_relationships and test_combination_model
Hi,
Cheers, |
Thanks a lot for the checks and the comments, @javoha!
Anyway, I'd say both are rather minor aspects, can be adjusted after the merge :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this feature should be part of the core gempy functionality. In the future we should include the possibility to store results. Thanks @flohorovicic!
Description
This PR introduces JSON input/output functionality to GemPy, allowing users to save and load geological models in JSON format. This new feature provides:
The JSON format offers several advantages:
The implementation includes:
JsonIO
class withsave_model_to_json
andload_model_from_json
methodsKey improvements in latest commits:
Relates to #1003
Checklist