This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Repository navigation
Refactor chain address validation - #1105
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes address validation and representation across multiple blockchain crates by implementing a common AddressTrait and providing validate_address functions. It also introduces GemChainAddress in the gemstone crate for cross-platform compatibility via UniFFI and updates crate dependencies to support these changes. Feedback identifies a bug in the NearAddress implementation where as_bytes incorrectly returns hex string bytes instead of decoded address bytes, and suggests that TronAddress::as_bytes should return only the 20-byte payload for consistency.
gemcoder21
reviewed
May 1, 2026
gemcoder21
approved these changes
May 1, 2026
0xh3rman
force-pushed
the
h/address-refactoring
branch
from
May 4, 2026 13:37
d3a6f24 to
b7fd282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.