Repository navigation
Android: amount field keeps the caret where the user puts it - #1956
Merged
Merged
Conversation
gemcoder21
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: On Android the Buy, Sell and Send-in-fiat amount field put the caret only at the start or the end of the number: tapping between the digits of
$ 50and typing 7 gave$ 750, and the selection handle could not be dragged between the digits (reported from the dev Telegram group with a screencast). The field drew the currency symbol inside the text through a hand-written visual transformation whose offset mapping for a leading symbol returned only 0 or the text length.What changed:
Proof: Before, tapping between the digits of
$ 50and typing 7 gave$ 750and the handle could not be dragged between the digits; after, it gives$ 570and the handle lands where it is dropped, in Buy, Sell and Send in both input modes, including German and Arabic locales and font scale 2.0. The field, Buy/Sell and Send view model tests pass; the field test now pins the symbol beside the amount. Not run: Maestro flows, the read-only amount (claim rewards) and the perpetual amount screen on a device.Behavior change: in right-to-left languages the crypto amount reads
0 USDTinstead of the mirroredUSDT 0; tapping the currency symbol no longer focuses the field, only the digits do; an empty fiat amount shows the caret before the0placeholder.