-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize GOC:cjm
references to use ORCID
#24694
base: master
Are you sure you want to change the base?
Conversation
This PR demonstrates updating the provenance in various places to use ORCID identifiers as a more actionable reference for @cmungall instead of `GOC:cjm`
GOC:cjm
references to use ORCID
@kltm I think this is ready for review. It appears a CI command has failed due to some issue with it interacting with GitHub's API, so I'm not sure if it has any relevant feedback or not |
@cthoyt just wanted to note the reason why I have delayed merging this. There are a number of issues with the OBO format OWL translation which we're working on, including mapping CURIE values to actual IRI resources rather than strings (owlcs/owlapi#1072). As it stands, all these |
I think we should also shoot for cleanly clearing tests for any merge, regardless of reason. If a test cannot consistently run, it should be removed. |
Only the ontology_qc test is required for merge. The others are informational. The last one fails for PRs outside the org (probably something I can fix with better configuration). |
Thanks for the note @balhoff. If there’s anything I can do to support you, please let me know. |
@balhoff if I change the ORCID CURIEs to URIs (and resolve conflicts), can this get merged? |
@balhoff Would this have any consequences for the Noctua data flow and client expectations? If so, we'll want to take and changes slowly. |
As a follow-up to cthoyt/orcidio#5, this PR demonstrates updating the provenance in various places to use ORCID identifiers as a more actionable reference for @cmungall instead of
GOC:cjm
As part of this PR, I also issued geneontology/go-site#1956, which adds
orcid
to the GO registry because the following code relies on the live deploy of this file for validation of xrefs:go-ontology/src/ontology/Makefile
Lines 152 to 159 in 4e61ae2