-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Update all packages and pin Bun version #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit updates all dependencies to their latest versions using `bun update --latest`. It also pins the Bun version to 1.2.21 in the GitHub workflow files and pins `@types/bun` to 1.2.21 in `package.json`.
WalkthroughBumps Bun version in GitHub Actions workflows from 1.2.19 to 1.2.21 and updates several dependencies and devDependencies in package.json (eslint, @eslint/js, typescript-eslint, @types/bun, TypeScript peer, @modelcontextprotocol/sdk, axios). No functional workflow logic or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
25-25
: Bun 1.2.21 pin — OK; consider building explicitly before publishPrepublishOnly will run the build, but adding an explicit “Build” step surfaces failures earlier in logs and keeps CI intent clear.
- name: Install Dependencies run: bun install --frozen-lockfile + - name: Build + run: bun run build + - name: Publish env: NPM_CONFIG_TOKEN: ${{ secrets.NPM_TOKEN }} TAG: ${{ github.event.release.prerelease && 'canary' || 'latest' }} run: bun publish --tag=${{ env.TAG }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
bun.lock
is excluded by!**/*.lock
📒 Files selected for processing (4)
.github/workflows/lint.yml
(1 hunks).github/workflows/release.yml
(1 hunks).github/workflows/test.yml
(1 hunks)package.json
(1 hunks)
🔇 Additional comments (4)
.github/workflows/lint.yml (1)
20-20
: Pinning Bun to 1.2.21 — LGTMMatches @types/bun 1.2.21 in package.json. No concerns.
.github/workflows/test.yml (1)
20-20
: Bun 1.2.21 pin — LGTMConsistent with lint and release workflows.
package.json (2)
43-49
: Flat ESLint config detected; please verify linting with ESLint 9 & typescript-eslint 8.41
- A flat-config file (
eslint.config.js
) is present at the project root.- Please run your lint script locally (e.g.
npm run lint
,yarn lint
orbun run lint
) to ensure ESLint 9 + typescript-eslint 8.41 produce no deprecation warnings or errors.
54-56
: Sanity-check bumped dependencies before mergeThe updates to
@modelcontextprotocol/[email protected]
andaxios@^1.11.0
may introduce subtle API or behavioral changes. Please verify:
- Type-checking still passes by running your build pipeline (e.g.
ornpm run build # runs tsc && tsc-alias
yarn build ```)
- All automated tests still pass (e.g.
or your project’s test runner). If you haven’t defined anpm test
test
script, either add one or invoke your test command directly (e.g.jest
,vitest
, etc.).- Any critical integration points in your code that rely on these dependencies are still exercising the intended behavior.
Once you’ve confirmed both type-checks and tests are green and manually spot-checked key API calls, this bump is safe to merge.
}, | ||
"peerDependencies": { | ||
"typescript": "^5.8.3" | ||
"typescript": "^5.9.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Build may fail in Release: TypeScript is only a peerDependency
Release uses “prepublishOnly” -> “bun run build”, which runs tsc. Because TypeScript is listed only as a peerDependency, CI won’t install it during “bun install --frozen-lockfile”, and the build can fail. Add TypeScript as a devDependency (keep the peerDependency for consumers).
"devDependencies": {
"@eslint/js": "^9.34.0",
"@types/bun": "1.2.21",
"eslint": "^9.34.0",
"prettier": "^3.6.2",
"tsc-alias": "^1.8.16",
- "typescript-eslint": "^8.41.0"
+ "typescript-eslint": "^8.41.0",
+ "typescript": "^5.9.2"
},
"peerDependencies": {
"typescript": "^5.9.2"
},
🏁 Script executed:
#!/bin/bash
# Validate tsc availability and version resolution used by the build.
jq -r '.devDependencies.typescript, .peerDependencies.typescript' package.json
bun x tsc -v || echo "TypeScript not installed in dev deps"
Length of output: 284
Add TypeScript to devDependencies to prevent build failures
Your verification script confirms that TypeScript is only listed as a peerDependency (shown as ^5.9.2
) and is absent from devDependencies
(null), so the build step (bun run build
→ tsc
) will fail in CI without installing TypeScript first.
• File: package.json
– Under "devDependencies"
, add "typescript": "^5.9.2"
Proposed diff:
"devDependencies": {
"@eslint/js": "^9.34.0",
"@types/bun": "1.2.21",
"eslint": "^9.34.0",
"prettier": "^3.6.2",
"tsc-alias": "^1.8.16",
- "typescript-eslint": "^8.41.0"
+ "typescript-eslint": "^8.41.0",
+ "typescript": "^5.9.2"
},
"peerDependencies": {
"typescript": "^5.9.2"
},
This ensures tsc
is available during your prepublishOnly
build without affecting consumers (who still benefit from the peerDependency version constraint).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"typescript": "^5.9.2" | |
"devDependencies": { | |
"@eslint/js": "^9.34.0", | |
"@types/bun": "1.2.21", | |
"eslint": "^9.34.0", | |
"prettier": "^3.6.2", | |
"tsc-alias": "^1.8.16", | |
"typescript-eslint": "^8.41.0", | |
"typescript": "^5.9.2" | |
}, | |
"peerDependencies": { | |
"typescript": "^5.9.2" | |
}, |
🤖 Prompt for AI Agents
In package.json around line 51, add "typescript": "^5.9.2" to the
"devDependencies" section so that tsc is available during CI/local builds; keep
the existing peerDependency entry unchanged and ensure package.json remains
valid JSON (comma placement and quoting) after inserting the new devDependency.
This commit updates all dependencies to their latest versions using
bun update --latest
.It also pins the Bun version to 1.2.21 in the GitHub workflow files and pins
@types/bun
to 1.2.21 inpackage.json
.Summary by CodeRabbit