Skip to content

fix trollstorehelper not being enabled by itself#9

Closed
speedyfriend433 wants to merge 3 commits intogeode-sdk:mainfrom
speedyfriend433:main
Closed

fix trollstorehelper not being enabled by itself#9
speedyfriend433 wants to merge 3 commits intogeode-sdk:mainfrom
speedyfriend433:main

Conversation

@speedyfriend433
Copy link

is it just for me or anyone cuz it crashes when i launch through trollstore with trollstorehelper failed 3 error message so i just fixed it..

#import <Foundation/Foundation.h>

#ifndef AppLog
#define AppLog(fmt, ...) NSLog((@"%s [Line %d] " fmt), __PRETTY_FUNCTION__, __LINE__, ##__VA_ARGS__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, use the AppLog provided from LogUtils

return;
}

strlcpy(path, "/var/containers/Bundle/Application/Geode.app/Geode", sizeof(path));
Copy link
Member

@FireMario211 FireMario211 Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/containers/Bundle/Application/Geode.app/Geode isn't a valid directory. I tested navigating it myself in NewTerm.

The binary also isn't called Geode.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t mean to add pull request with this too lol
It was just a placeholder part and uhh it automatically added the part 🥶

@FireMario211
Copy link
Member

FireMario211 commented Jul 8, 2025

This pull request has not been updated to fix the merge conflicts, nor does it seem to do much of everything (mostly dead code).

There are unnecessary files created in the ZSign directory that never get used. (I don't even think apple allows rwx! We do swapping between rw and rx)
Additionally there are unnecessary untabs that break formatting, and the executable_patch.m seems to be doing the same thing as the one in main.m (the func isnt called at all!), which makes me question if this code had been tested at all or if it fixes the problem the PR states.

Until these issues are fixed, the PR will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants