Fixing SingleBand pseudocolor band selector bug #998
+114
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
mfisher87
reviewed
Nov 20, 2025
| bandsArr.push({ | ||
| band: i, | ||
| bands.push({ | ||
| band: i + 1, |
Member
There was a problem hiding this comment.
This is the core of the fix, right? Are the rest of the changes necessary to fix this bug? Apologies, I've forgotten some of the context around this issue :)
Contributor
Author
There was a problem hiding this comment.
Yes this is the core fix. Rest of changes is also necessary because if we fix only in the useGetBandInfo so the Singleband bug teleport to Multiband because we are using common hook in both useGetBandInfo. More info here #912 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing SingleBand pseudocolor band selector bug by separating hooks into
useGetSingleBandInfoanduseGetMultiBandInfo. The idea of separation ofuseGetBandInfoarise in #912 (comment)cc @mfisher87 @martinRenou
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--998.org.readthedocs.build/en/998/
💡 JupyterLite preview: https://jupytergis--998.org.readthedocs.build/en/998/lite