Datahub: Add pagination for table component #1120
Conversation
|
Affected libs:
|
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Thank you!! that looks really good! I'll try this alongside with the PR from @AlitaBernachot and see if everything goes according to plan ;)
| this.properties = | ||
| Array.isArray(value) && value.length ? Object.keys(value[0]) : [] | ||
| this.count = value.length | ||
| export class TableComponent implements OnInit, AfterViewInit, OnChanges { |
There was a problem hiding this comment.
What do you think of renaming this component DataTableComponent ?
There was a problem hiding this comment.
Hum, and then I rename the TableScrollComponent back to TableComponent which it actually was in the beginning? Would that make sense to you, a TableComponent that accepts datasets and a DataTableComponent that accepts data readers?
There was a problem hiding this comment.
I think we can just get rid of the table scroll component, unless it has some use still?
There was a problem hiding this comment.
I thought to keep it temporarily for the geo-table-view.component which has various issues to work with the new TableComponent.
| // export const WithWfs: StoryObj<TableComponent> = { | ||
| // loaders: [ | ||
| // async () => ({ | ||
| // dataset: await openDataset( |
There was a problem hiding this comment.
Hello, small change, function signature has changed:
await openDataset(
'https://www.geo2france.fr/geoserver/cr_hdf/ows',
'wfs',
{
wfsFeatureType: 'accidento_hdf_L93',
}
),
`
and fix horizontal scroll
and keep loading state in table-view.component
jahow
force-pushed
the
paginate-table-compoonent
branch
from
b404f14 to
4e531b2
Compare
… and use it in the geo-table-view.component
Also make the footer the same size as before
jahow
force-pushed
the
paginate-table-compoonent
branch
from
4e531b2 to
ad9f43e
Compare
jahow
force-pushed
the
paginate-table-compoonent
branch
from
ad9f43e to
cabd2ba
Compare
Description
This PR introduces pagination to the
table.componentTodos:
Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>label