Add header-config-file #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landryb
reviewed
Feb 6, 2025
default.properties
Outdated
| @@ -42,6 +42,12 @@ headerUrl=/header/ | |||
| # Default empty string | |||
| # georchestraStylesheet=http://my-domain-name/stylesheet.css | |||
|
|
|||
| # Config file for the header webcomponent | |||
| # You can use this file to change the menu design, add new items, etc. | |||
| # Full configuration cna be found here: https://github.com/georchestra/header/ | |||
landryb
reviewed
Feb 6, 2025
default.properties
Outdated
| # You can use this file to change the menu design, add new items, etc. | ||
| # Full configuration cna be found here: https://github.com/georchestra/header/ | ||
| # Default empty string | ||
| # headerConfigFile=http://my-domain-name/public/config.json |
There was a problem hiding this comment.
shouldnt we show that urls without the fqdn should be preferred, eg /public/config.json ? helps for dev/staging/prod urls
landryb
approved these changes
Feb 6, 2025
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions bot
added a commit
that referenced
this pull request
Feb 6, 2025
[docker-master] Merge pull request #435 from georchestra/header-config-file
|
@f-necas given what was done for the defaults in georchestra/header#25, shouldnt the default height be changed with |
|
yep, I forgot it every time |
landryb
added a commit
to georchestra/ansible
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.