-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ScanAllSets to the api #115
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 82.74% 80.41% -2.34%
==========================================
Files 5 5
Lines 510 531 +21
==========================================
+ Hits 422 427 +5
- Misses 73 89 +16
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @kmpm, thank you for adding this new feature to the library. The code and tests look great. Let me think about it from the design point of view for a bit, though. If I have any questions, I will let you know. |
@georgysavva, you closed the issue I was refering to as completed so I kind of hoped you would have accepted the PR, but no. |
@kmpm, thank you for your work, and sorry for taking so much time to merge your PR. Here is the new release containing this feature: https://github.com/georgysavva/scany/releases/tag/v2.1.0 |
I made a new function in the API for getting all result sets from sql.Rows.
My use case for this is a 3rd party application that uses mssql and have stored procedures returning multiple different results.
Possibly also a solution for #114
Tests can be run if you have a Sql Server up an running somewhere and run the tests with the tag
with_mssql
.