Cache columeToIndexFieldMap #131
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 80.72% 81.02% +0.30%
==========================================
Files 5 5
Lines 555 564 +9
==========================================
+ Hits 448 457 +9
Misses 92 92
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| type API struct { | ||
| structTagKey string | ||
| columnSeparator string | ||
| fieldMapperFn NameMapperFunc | ||
| scannableTypesOption []interface{} | ||
| scannableTypesReflect []reflect.Type | ||
| allowUnknownColumns bool | ||
| // columnToIndexFieldMapCache stores a map of reflect.Type -> map[string][]int | ||
| columnToIndexFieldMapCache sync.Map |
There was a problem hiding this comment.
I went back and forth on whether this should store a sync.Map itself or a pointer to a (heap-allocated) one. IMO both ways have risk of improper use. If we store the Map directly, the user could copy the API while the map is being updated. On the other hand, if we use a pointer, the value might not get initialized. (Or we would need to initialize it lazily, which adds some complexity and synchronization overhead.) I'm happy to change to another solution if you feel strongly.
|
This looks great, thank you. This PR fixes #25. |
|
@zolstein here is the new release: https://github.com/georgysavva/scany/releases/tag/v2.1.2 |
No description provided.