Limit recursive struct scan level #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgysavva
requested changes
Aug 2, 2021
Comment on lines
+25
to
+40
| visitedTypes := make(map[reflect.Type]int) | ||
| for len(queue) > 0 { | ||
| traversal := queue[0] | ||
| queue = queue[1:] | ||
| structType := traversal.Type | ||
|
|
||
| // remember visited types and number of visits. | ||
| if structType.Kind() == reflect.Struct { | ||
| if visitCount, visited := visitedTypes[structType]; !visited { | ||
| visitedTypes[structType] = 1 | ||
| } else if visitCount < MaxStructRecursionLevel { | ||
| visitedTypes[structType] = visitCount + 1 | ||
| } else { | ||
| continue | ||
| } | ||
| } |
There was a problem hiding this comment.
The visitedTypes variable is global for the whole traversal, it counts all type encounters even is separate branches. We should judge recursion only on types that were visited on the path to the current type, i.e. only the current branch of the traversal.
I think we should add visitedTypes as a field to the toTraverse struct, so would every type we iterate over had it's own set of previously visited types.
Comment on lines
+75
to
77
| for childType.Kind() == reflect.Ptr { | ||
| childType = childType.Elem() | ||
| } |
|
Closing due to inactvity. Feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #57.