Switching to installed python when vim is not compiled with +python3 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-bobyr
reviewed
Jul 28, 2025
| @@ -5,6 +5,31 @@ let s:buf = -1 | |||
| " avoid starting a 2nd edit job while one is in progress | |||
| let g:edit_in_progress = 0 | |||
|
|
|||
| if !exists('g:ollama_embedded_python') || g:ollama_embedded_python == 0 | |||
There was a problem hiding this comment.
Perhaps it would be better to perform the "is embedded Python" available check as the first expression of the corresponding function?
This way it would be closer to the reset of the relevant code.
When a function that uses embedded Python is added or removed, it is easier to see that one also needs to think about a case when Python is not available.
| @@ -379,6 +379,8 @@ function! ollama#setup#EnsureVenv() abort | |||
| endfunction | |||
|
|
|||
| " Loads the plugin's python modules | |||
|
|
|||
| if g:ollama_embedded_python | |||
There was a problem hiding this comment.
In autoload/ollama/edit.vim you defined alternative function body, but here you are skipping the function definition.
Both works, but it seems a bit inconsistent.
I would suggest doing a check as the first statement and show a helpful error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually work with preinstalled versions of vim which doesn't have
+python3compiled and I see that in this case the plugin is fully disabled.This PR will switch to the python version installed in the system in case embedded python is not found and only
OllamaEditwill be disabled (error messages are displayed if the user tries to use it).