fix: resolve stale closure bug in fetchToken callback #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fetchToken callback in ConvexBetterAuthProvider had incorrect dependencies, causing it to capture stale authClient references. This prevented Convex JWT token fetching from working correctly when authClient prop changed or plugins were dynamically loaded. - Updated dependency array from [client] to [authClient, logVerbose] - Ensures callback updates when authClient changes (fixing dynamic plugin loading) - Fixes silent authentication failures in mobile/native apps using Better Auth with Convex 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Yeah this is fair, but we also still want to invalidate if the convex client changes. I think this fix only affects dynamic client plugin loading use cases, did you see mobile/native being affected beyond that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetchToken callback in ConvexBetterAuthProvider had incorrect dependencies, causing it to capture stale authClient references. This prevented Convex JWT token fetching from working correctly when authClient prop changed or plugins were dynamically loaded.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.