-
Notifications
You must be signed in to change notification settings - Fork 67
Use the explicit table name APIs everywhere #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis PR systematically updates database operation calls across the codebase to pass explicit table/collection names as the first argument to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
package.json
Outdated
| "devDependencies": { | ||
| "@arethetypeswrong/cli": "0.18.2", | ||
| "@convex-dev/eslint-plugin": "1.0.0", | ||
| "@convex-dev/eslint-plugin": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally we pin dev dependencies and have it auto-update them via renovate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done in 9041e6b
ianmacartney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - just a few instances in the migrations helper to go. aside: we should probably deprecate the migrations helper in favor of the component
| try { | ||
| const next = await migrateOne(ctx, doc); | ||
| if (next && Object.keys(next).length > 0) { | ||
| await ctx.db.patch(doc._id as GenericId<TableName>, next); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| await ctx.db.patch(table, doc._id as GenericId<TableName>, next); |
|
Thanks @ianmacartney! I’m moving this back to draft, as I realized that there are some other helpers that would benefit from supporting the new APIs. |
@convex-dev/eslint-plugin to 1.1.00abef26 to
101d6cf
Compare
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Summary by CodeRabbit
Refactor
Chores
✏️ Tip: You can customize this high-level summary in your review settings.