Investigate Convex JS pull request issues #120
+83
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MCP server was unconditionally requiring BigBrain (Convex Cloud) authentication for all tool calls, which caused local, anonymous, and self-hosted deployments to fail with "Not Authorized" error. Changes: - Add requiresBigBrainAuth() method to RequestContext that checks deployment type before requiring cloud authentication - Add requiresBigBrainAuthForDeployment() helper function - Modify MCP tool handler to use smart auth checking - Add clear usage documentation in --help for different deployment types Deployment types that NO LONGER require cloud login: - Self-hosted (CONVEX_SELF_HOSTED_URL + CONVEX_SELF_HOSTED_ADMIN_KEY) - CLI direct (--url + --admin-key) - Anonymous local development (CONVEX_AGENT_MODE=anonymous) Deployment types that STILL require cloud login: - Cloud-hosted projects (CONVEX_DEPLOYMENT) - Deploy key based (CONVEX_DEPLOY_KEY) - Preview deployments Fixes: get-convex#78 Related: PR get-convex#92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP server was unconditionally requiring BigBrain (Convex Cloud) authentication for all tool calls, which caused local, anonymous, and self-hosted deployments to fail with "Not Authorized" error.
Changes:
Deployment types that NO LONGER require cloud login:
Deployment types that STILL require cloud login:
Fixes: #78
Related: PR #92
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.