Fix: prevent Enter submit while IME composing (CJK) #278
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix: prevent Enter submit while IME composing (CJK)
Problem
Changes
FloatingPromptInput
:onCompositionStart
/onCompositionEnd
.nativeEvent.isComposing
and a fallbackkeyCode === 229
check for environments that report 229 during composition.src/components/FloatingPromptInput.tsx
Behavior (after)
Risk / Scope
FloatingPromptInput
.Test Plan
Notes
Checklist