Feature: Add proxy authentication support with username/password #315
+437
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinker0
changed the title
Add proxy authentication support with username/password # Description This PR adds the ability to use authenticated proxies by including username and password credentials in proxy URLs. # Changes - Added username and password fields to ProxySettings struct - Extended database storage and retrieval for proxy credentials - Added authentication to proxy URLs using the standard format (http://username:password@hostname:port) - Added secure handling of credentials (password masking in UI, credentials hiding in logs) - Added comprehensive test coverage for the authentication functionality # Features - Users can now set proxy username and password in the proxy settings UI - Credentials are automatically applied to HTTP, HTTPS, and ALL proxy settings - Credentials are securely stored in the application database - Works with any proxy server that supports basic authentication # Testing - Added unit tests for URL construction with authentication - Added tests for environment variable handling with credentials - Added tests for database storage and retrieval of credentials - Tested complex URLs with paths, query parameters, and special characters This enhancement allows users to connect through proxies that require authentication, which is commonly needed in corporate environments.
thinker0
force-pushed
the
feature/support-password-of-proxy
branch
from
aa080c1 to
cd37b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proxy authentication support with username/password
Description
This PR adds the ability to use authenticated proxies by including username and password credentials in proxy URLs.
Changes
Features
Testing
Added unit tests for URL construction with authentication
Added tests for environment variable handling with credentials
Tested complex URLs with paths, query parameters, and special characters
This enhancement allows users to connect through proxies that require authentication, which is commonly needed in corporate environments.