Skip to content

[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: istanbul/develop
Choose a base branch
from
Open

[WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators #123

wants to merge 20 commits into from

Conversation

@markya0616
Copy link

…poser and validators

markya0616
markya0616 commented Jul 17, 2017
View reviewed changes
consensus/istanbul/core/preprepare.go Outdated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core isProposer()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

markya0616
markya0616 commented Jul 17, 2017
View reviewed changes
core/blockchain.go Outdated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.Debug

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@markya0616 markya0616 changed the base branch from improve_performance to feature/improve_performance July 18, 2017 02:29
@markya0616 markya0616 force-pushed the feature/improve_performance branch from bdfa43e to 6816e21 Compare July 18, 2017 02:30
@yutelin yutelin changed the title consensus, core, eth, miner: use the same insert behavior between pro… consensus, core, eth, miner: use the same insert behavior between proposer and validators Jul 21, 2017
yutelin
yutelin reviewed Jul 21, 2017
View reviewed changes
consensus/istanbul/backend/backend.go Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment more on commitProposedWork and writeProposedWork

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@yutelin
Copy link

yutelin commented Jul 21, 2017

Please elaborate what the major difference from previous implementation is.
What we did before and what we do right now.

For example, previously proposer inserts the block through __ and validator insert the block through __.
And now, proposer and validators are the same. They call commitProposedWork during __ step to __? And call writeProposedWork during __ step for __ ?

@markya0616 markya0616 force-pushed the feature/improve_performance branch from 6816e21 to 39eaf7c Compare July 22, 2017 13:20
@markya0616 markya0616 changed the base branch from feature/improve_performance to istanbul/develop July 24, 2017 06:45
@markya0616
Copy link
Author

OK. In previous implementation, we only verify block's header in Verify() and call InsertChain to insert committed blocks. We don't check the correctness of the block body in Verfiy(), so we may try to lock or commit a block with incorrect body. In this PR, we created an Istanbul worker to improve system performance and check block body (i.e., transactions) in Verify().
The procedure are as follows:

  1. Proposer call commitNewWork() to create a block after receiving NewBlockEvent event
  2. Proposer broadcasts the proposed blocks to other validators
  3. After validators received the proposed block, they call commitProposedWork() and then apply the transactions in the block to check the correctness of the block's body and header.
  4. If we received 2F+1 commits, we call writeProposedWork() to write the committed block into chain db.

tailingchen and others added 16 commits July 31, 2017 17:48
@tailingchen
eth: add protocol manager interface and refactoring
7791eac
@markya0616 @tailingchen
params: add Istanbul consensus engine config to ChainConfig
6f01d12
@bailantaotao @tailingchen
cmd/*: add Istanbul command line flags
5e8aa15
@bailantaotao @tailingchen
consensus/istanbul, eth: add Istanbul configuration
219aa5e
@tailingchen
node: add an interface to retrieve node key from config
b7366b3
@tailingchen
consensus: add Istanbul consensus engine interface
da8d588
@tailingchen
consensus/istanbul: common Istanbul interfaces and types
519ec6e
@tailingchen
consensus/istanbul: Istanbul validator set implementation
885035c
@tailingchen
consensus/istanbul: Istanbul core implementation
e69dedf
@bailantaotao @tailingchen
consensus/istanbul: add tests for Istanbul core
49aa279
@bailantaotao @tailingchen
core/types: add Istanbul specific block hash calculation
2ce3c53
@markya0616 @tailingchen
consensus/istanbul: Istanbul consensus backend implementation
443b0f9
@bailantaotao @tailingchen
internal/web3ext: add Istanbul JS RPC API
e2d561f
@tailingchen
eth: Istanbul consensus integration
2b7bda3
@markya0616 @tailingchen
cmd/*, core, params: add ottoman testnet
f2f493b
@markya0616 @tailingchen
consensus/istanbul: set timeout based on round
3730ecf
markya0616 and others added 2 commits August 1, 2017 14:41
@markya0616
consensus/*, eth, ethstats, miner: add block lock and some features
41dfb17 
* consensus/istanbul: handle future preprepare
* consensus/istanbul: handle request timeout in evnet loop
* consensus, eth: start/stop core engine while start/stop mining
* eth, ethstats: fix crash while reporting to ethstats
* consensus/istanbul, miner: add new event to trigger new block creation
* eth, consensus/istanbul: improve sending messages
* consensus/istanbul: stop future preprepare timer while stop core
* consensus/istanbul: add cache in ecrecover()
@yutelin @markya0616
travis: update travis notification url
2d811e4
@markya0616 markya0616 changed the title consensus, core, eth, miner: use the same insert behavior between proposer and validators [WIP] consensus, core, eth, miner: use the same insert behavior between proposer and validators Aug 8, 2017
@markya0616
Copy link
Author

This PR changes too many stuffs. We need more tests for this PR before merge

@markya0616 markya0616 force-pushed the istanbul/develop branch 3 times, most recently from f152944 to adc0cb8 Compare August 25, 2017 07:12
@markya0616 markya0616 force-pushed the istanbul/develop branch 2 times, most recently from 1d28a1c to 6eb4e85 Compare September 15, 2017 07:09
@markya0616 markya0616 force-pushed the istanbul/develop branch 2 times, most recently from b389e13 to cfc586a Compare October 4, 2017 03:06
@markya0616 markya0616 force-pushed the istanbul/develop branch 2 times, most recently from cb3c2e1 to 3d49176 Compare January 23, 2018 01:59
@stevenroose
Copy link

stevenroose commented Jan 24, 2018 •
edited
Loading

Where can I report issues with Istanbul? I found one that might be slightly related to this change.

It's explained here in more detail: ethereum/EIPs#650 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yutelin yutelin yutelin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markya0616 @yutelin @stevenroose @tailingchen @bailantaotao