Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
.github/workflows/pr.yml
Outdated
| test-app-tools: | ||
| runs-on: macos-26 | ||
| timeout-minutes: 60 | ||
| needs: detect-app-changes | ||
| if: ${{ needs.detect-app-changes.outputs.app-tools == 'true' }} | ||
| steps: |
There was a problem hiding this comment.
The newly added filters expose outputs like app-tools and local-server, but the downstream jobs use the dot notation ${{ needs.detect-app-changes.outputs.app-tools == 'true' }} (similar for local-server). In GitHub Actions expressions a hyphen is treated as the subtraction operator, so this expression is parsed as outputs.app - tools and fails evaluation before the workflow even starts. As a result any PR that reaches this workflow will error out at parse time. Either rename these outputs to snake_case or access them with bracket notation (e.g. ${{ needs.detect-app-changes.outputs['app-tools'] == 'true' }}) everywhere they are used.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
.github/workflows/pr.yml
Outdated
| test-app-tools: | ||
| runs-on: macos-26 | ||
| timeout-minutes: 60 | ||
| needs: detect-app-changes | ||
| if: ${{ needs.detect-app-changes.outputs.app-tools == 'true' }} | ||
| steps: |
There was a problem hiding this comment.
The newly added filters expose outputs like app-tools and local-server, but the downstream jobs use the dot notation ${{ needs.detect-app-changes.outputs.app-tools == 'true' }} (similar for local-server). In GitHub Actions expressions a hyphen is treated as the subtraction operator, so this expression is parsed as outputs.app - tools and fails evaluation before the workflow even starts. As a result any PR that reaches this workflow will error out at parse time. Either rename these outputs to snake_case or access them with bracket notation (e.g. ${{ needs.detect-app-changes.outputs['app-tools'] == 'true' }}) everywhere they are used.
Useful? React with 👍 / 👎.
gsabran
force-pushed
the
gsabran/split-ci-tests
branch
from
986dbce to
c3727ea
Compare
1 participant
Improve CI by splitting some jobs, making them run more selectively, and hopefully improving caching