Skip to content

Update request.js #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update request.js #77

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c875f7
Update request.js
tomfuertes Dec 10, 2019
2c4dcac
Update request.js
tomfuertes Mar 18, 2020
1a1292a
Update request.js
tomfuertes Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,29 @@ class Request {
res.on('end', () => {
logger('Request complete');


if (res.statusCode >= 400 && res.statusCode <= 600) {
if (shouldUnzip) {
const unzip = contentEncoding === 'deflate' ? zlib.deflate : zlib.gunzip;
return unzip(Buffer.from(body, encoding), (err, data) => {
if (err) {
return reject(err);
}

const error = new Error(`Request returned error code: ${res.statusCode} and body: ${data.toString('utf8')}`);
error.code = res.statusCode;
error.responseBody = data.toString('utf8');
return reject(error);
});
}

const error = new Error(`Request returned error code: ${res.statusCode} and body: ${body}`);
error.code = res.statusCode;
error.responseBody = body;

return reject(error);
}

Copy link
Contributor

@syJSdev syJSdev Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these spaces

Copy link
Author

@tomfuertes tomfuertes Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syJSdev (removed)

// Use GZIP decompression if required
if (shouldUnzip) {
const unzip = contentEncoding === 'deflate' ? zlib.deflate : zlib.gunzip;
Expand Down