Reduce log spam when upstream interface is offline #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the suggested fix to a problem observed in the OpenWrt implementation of stubby (usually embedded in a router), where if the upstream interface went offline, the logs would rapidly be filled with "Could not schedule query". This fix was suggested by Andre Heider via @dhewg (See openwrt/packages#13726)
|
Yeah, and I'm still using this patch. But in this state it's probably not suitable for upstream. |
wtoorop
added a commit
that referenced
this pull request
Dec 22, 2022
This was referenced Jan 7, 2023
Closed
|
Stubby 0.4.3 + mwan3, now on OpenWrt is no messages at all about "Could not schedule query..." when there is all links offline. |
SibrenVasse
pushed a commit
to SibrenVasse/packages
that referenced
this pull request
Feb 26, 2023
Changelog from upstream (https://github.com/getdnsapi/stubby/blob/v0.4.3/ChangeLog): * 2022-12-22: version 0.4.3 * Fix Issue getdnsapi/stubby#330 and PR getdnsapi/stubby#324: PrivateUsers=false needed in systemd stubby.service file for stubby to start. Thanks Archcan and Petr Menšík * PR getdnsapi/stubby#323: Reduce log messages when interface is offline. Thanks Russ Bubley and Andre Heider * 2022-08-19: version 0.4.2 * Fix Issue getdnsapi/stubby#320: Stubby doesn't start without "log_level" entry. Thanks Johnny S. Lee * 2022-08-19: Version 0.4.1 * Several updates to the servers in the config file: * sinodun.dnsovertls*.com servers are removed and will be decommissioned in the near future. This leaves only the getdnsapi.net server as the default. A recommendation is made that users choose additional servers from the list available. * Additional Quad9 servers added (thanks pataquets). * LDN servers removed as the service is now stopped. * Tidy up of remaining server data. * Change `comment` lines on Uncensored server data to more clearly be comments (not valid YAML) * Fix and improve descriptions of default values * getdnsapi.net DoT servers liston on port 443 now too * Fixes for parsing of quoted key values for `tls-ca-file`, `tls-curves-list` and `resolvconf` * Add Dockerfile into `contrib` - thanks to pataquets. * Strengthen version checking for LibIDN2 during the cmake step so LibIDN2 version 2.3.3 can be properly found (thanks jpbion). * Updated stubby.service file. Thanks Bruno Pagani * log level configurable in config file with log_level setting Command line setting (with -v or -l) overrules the config file setting Signed-off-by: Aquila Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the suggested fix to a problem observed in the OpenWrt implementation of stubby (usually embedded in a router), where if the upstream interface went offline, the logs would rapidly be filled with "Could not schedule query". This fix was suggested by Andre Heider via @dhewg (See openwrt/packages#13726)