You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
validate create_image follower RPCs against their internal imageBase64 payload
surface validation errors returned by the leader instead of only reporting HTTP 400
add regression coverage for follower payload validation and error propagation
Root cause
The follower resolves the public source argument to imageBase64 before forwarding the request. The leader then validated that internal request with the public createImageInput schema, which still required source, so valid follower calls were rejected with HTTP 400.
Impact
create_image now works when the calling MCP process is a follower, and future leader-side validation errors remain actionable.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 50db224d-255a-4c41-9010-a53b1a104266
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_imagefollower RPCs against their internalimageBase64payloadRoot cause
The follower resolves the public
sourceargument toimageBase64before forwarding the request. The leader then validated that internal request with the publiccreateImageInputschema, which still requiredsource, so valid follower calls were rejected with HTTP 400.Impact
create_imagenow works when the calling MCP process is a follower, and future leader-side validation errors remain actionable.Validation
npm testFixes #35