Skip to content

[codex] Fix create_image follower RPC validation - #36

Draft
guowenlong123 wants to merge 1 commit into
gethopp:mainfrom
guowenlong123:fix/create-image-rpc-400
Draft

[codex] Fix create_image follower RPC validation#36
guowenlong123 wants to merge 1 commit into
gethopp:mainfrom
guowenlong123:fix/create-image-rpc-400

Conversation

@guowenlong123

Copy link
Copy Markdown

Summary

  • validate create_image follower RPCs against their internal imageBase64 payload
  • surface validation errors returned by the leader instead of only reporting HTTP 400
  • add regression coverage for follower payload validation and error propagation

Root cause

The follower resolves the public source argument to imageBase64 before forwarding the request. The leader then validated that internal request with the public createImageInput schema, which still required source, so valid follower calls were rejected with HTTP 400.

Impact

create_image now works when the calling MCP process is a follower, and future leader-side validation errors remain actionable.

Validation

  • npm test
  • 2 tests passed
  • TypeScript build passed

Fixes #35

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 50db224d-255a-4c41-9010-a53b1a104266

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create_image Leader returned status 400

3 participants