improvement: stop screen-share from camera window

[iparaskev]

The camera window allows to also stop the screen-share other than just triggering the content picker.

Also this commit fixes a bug where the content picker was clearing the screen-share overlay if it was cancelled during a screen-share.

Summary by CodeRabbit

• New Features

  • Improved screen sharing controls with clearer active-sharing feedback.
  • Added a dropdown option to choose screen-sharing content.
  • Automatically prioritizes the monitor containing the cursor when selecting a screen on macOS.

• Bug Fixes

  • Improved monitor window handling when screen selection is hidden, preserving the active monitor view.

[netlify]

✅ Deploy Preview for hoppdocs ready!

Name	Link
🔨 Latest commit	4de6675
🔍 Latest deploy log	https://app.netlify.com/projects/hoppdocs/deploys/6a770851453f9f000835002b
😎 Deploy Preview	https://deploy-preview-377--hoppdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9876ee21-afcd-46c0-89b6-850031cb5014

📥 Commits

Reviewing files that changed from the base of the PR and between 01e59cf and 4de6675.

📒 Files selected for processing (2)

• core/src/window/camera_window.rs
• core/src/window_manager.rs

---

📝 Walkthrough

Walkthrough

The change adds a screen-share picker action, updates screen-share button state and handling, and changes monitor selection and hiding behavior for screen-sharing windows.

Changes

Screen sharing flow

Layer / File(s)	Summary
Camera screen-share controls core/src/window/camera_window.rs	CameraMessage now includes OpenScreenSharePicker. The screen-share button reflects the local participant’s active sharing state, opens the picker, stops active sharing, or requests available content.
Monitor selection behavior core/src/window_manager.rs	macOS selection prioritizes the monitor containing the cursor. Hiding screen selection preserves and re-renders the active monitor while hiding and resizing inactive windows.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• gethopp/hopp#353: Extends the screen-share picker replacement with related CameraMessage and WindowManager changes.
• gethopp/hopp#362: Modifies related screen-selection and picker navigation behavior.
• gethopp/hopp#363: Modifies related macOS screen-sharing selection and active-monitor handling.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: stopping screen sharing from the camera window.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch improve_screensharing_button_camera_window

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}