Skip to content

Conversation

@yaronshanisima
Copy link
Contributor

@yaronshanisima yaronshanisima commented Dec 17, 2025

otherwise this seems to break oauth2 proxy https://github.com/oauth2-proxy/oauth2-proxy which will return 401 with the uppercase

Description

describe the purpose of the change here

Resolves <issue nr here>

PR Checklist

otherwise this seems to break oauth2 proxy https://github.com/oauth2-proxy/oauth2-proxy which will return 401 with the uppercase
@davidradl
Copy link
Contributor

@yaronshanisima thanks for your PR submission. Please could you raise in issue, add a change log entry and why you did not add tests. I have kicked off the tests, it seems the rest of the code uses the correct casing.

Once you fix up the PR, and the PR build works, I will get this merged

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this change to the changelog, raise an issue and refer to it in this PR. I will then merge

@yaronshanisima
Copy link
Contributor Author

This PR fixes #205.

Changes made:

  • Fixed Bearer token casing from BEARER to Bearer in OIDCAuthHeaderValuePreprocessor.java to comply with RFC 6750
  • Added changelog entry under [Unreleased] section
  • Added unit tests using WireMock to verify the correct Bearer token casing

@davidradl
Copy link
Contributor

@yaronshanisima ooking good, the format checker is saying :

Error: /home/runner/work/flink-http-connector/flink-http-connector/src/test/java/com/getindata/connectors/http/internal/OIDCAuthHeaderValuePreprocessorTest.java:1: File does not end with a newline. [NewlineAtEndOfFile]

Please could you amend.

@davidradl davidradl self-requested a review December 19, 2025 11:13
@davidradl
Copy link
Contributor

@yaronshanisima I see you put fixed in the change log, it should be under unreleased - I will change on my next commit.

@davidradl davidradl merged commit 125c9ec into getindata:main Dec 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants