Skip to content

Conversation

jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Apr 26, 2024

No description provided.

@jigar-f jigar-f requested a review from myleshorton April 26, 2024 10:53
@@ -88,6 +89,9 @@ func TestPaymentMethodsV4(t *testing.T) {
user.UserID = res.User.ID
user.Token = res.User.Token

defer gock.Off()
mockGetRequest("/plans-v4", expectedPlansV4Response)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you already realize this, but UserCreate above also hits staging and also needs to be mocked. But that's the case for basically every test in this file... I guess we need to decide how much of this thread we want to pull.

Copy link
Contributor Author

@jigar-f jigar-f Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hwh33 for looking, But I forgot that we are working on #1371 PR that removed the proClient code and moves it to internalsdk, eventually we will write a test on internalsdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants