Don't create Pinia outside development #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already don't create Pinia stores outside development. By not creating Pinia at all, Pinia will no longer be included in the bundle. We only use Pinia in development.
matthew-white
commented
Dec 5, 2022
| @@ -45,7 +48,7 @@ export default ({ | |||
| logger = console | |||
| } = {}) => { | |||
| const container = { | |||
| pinia: createPinia(), | |||
| pinia: process.env.NODE_ENV === 'development' ? createPinia() : piniaMock, | |||
There was a problem hiding this comment.
Originally, my strategy was going to be to use webpack to alias the pinia package to src/util/pinia.js. That way, only our webpack config would change, not this file. However, at the end of the day, I think this approach is clearer: there's less webpack magic involved. Plus, now that we're planning to move to Vite (#671), it seems good to have as little webpack-specific code as possible. I checked the build, and even though this file still imports Pinia, if it doesn't use Pinia at all, which it won't outside development, the import is removed from the bundle.
Since we won't use it after all, I've removed src/util/pinia.js.
ktuite
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for notes.