Make small changes to ESLint config #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
May 9, 2024
Comment on lines
-10
to
-12
| env: { | ||
| node: true | ||
| }, |
There was a problem hiding this comment.
env tells ESLint which variables are global variables so it doesn't flag them. However, Frontend isn't a Node project, so specifying node here doesn't make sense. The actual global variables that we use are listed below under globals.
| ecmaVersion: 2020 | ||
| ecmaVersion: 'latest' |
There was a problem hiding this comment.
We target the latest two browser versions, so I think latest makes sense. We certainly aren't targeting 2020.
ktuite
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the default ESLint config from Vite has a few changes from ours (related: #671). This PR pulls in some of those changes now.
What has been done to verify that this works as intended?
Linting continues to pass.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes