Prevent any user from updating public bundles #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the web UI allows any logged in user to remove patches from public bundles. However the correct behaviour is that only the owner of the bundle should be allowed to update a bundle. Fix that by adding checks in set_bundle() before adding or removing patches from bundles. Signed-off-by: Abdun Nihaal <[email protected]> Closes: getpatchwork#599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the web UI allows any logged in user to remove patches from public bundles. However the correct behaviour is that only the owner of the bundle should be allowed to update a bundle.
Fix that by adding checks in set_bundle() before adding or removing patches from bundles.
Closes: #599
After fixing, when I try to remove a patch from a public bundle (without being an owner user), I get the following error message and the patch is not removed.