Add proxy protocol support #608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="pkg/probod/probod.go">
<violation number="1" location="pkg/probod/probod.go:586">
P3: Missing `span.RecordError(err)` before returning the error. Other error returns in this function follow the pattern of recording the error to the span for tracing purposes.</violation>
<violation number="2" location="pkg/probod/probod.go:594">
P2: The second `defer listener.Close()` is unnecessary and causes a double-close. When `proxyproto.Listener` is closed, it also closes the underlying `net.Listener`. The original defer (line 580) already handles closing the wrapped listener. Remove this defer to avoid closing the underlying listener twice.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
pkg/probod/probod.go
Outdated
| ReadHeaderTimeout: 10 * time.Second, | ||
| Policy: policy, | ||
| } | ||
| defer listener.Close() |
There was a problem hiding this comment.
P2: The second defer listener.Close() is unnecessary and causes a double-close. When proxyproto.Listener is closed, it also closes the underlying net.Listener. The original defer (line 580) already handles closing the wrapped listener. Remove this defer to avoid closing the underlying listener twice.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At pkg/probod/probod.go, line 594:
<comment>The second `defer listener.Close()` is unnecessary and causes a double-close. When `proxyproto.Listener` is closed, it also closes the underlying `net.Listener`. The original defer (line 580) already handles closing the wrapped listener. Remove this defer to avoid closing the underlying listener twice.</comment>
<file context>
@@ -578,6 +580,22 @@ func (impl *Implm) runApiServer(
+ ReadHeaderTimeout: 10 * time.Second,
+ Policy: policy,
+ }
+ defer listener.Close()
+
+ l.Info("using proxy protocol", log.String("trusted-proxies", strings.Join(impl.cfg.Api.ProxyProtocol.TrustedProxies, ", ")))
</file context>
pkg/probod/probod.go
Outdated
| if len(impl.cfg.Api.ProxyProtocol.TrustedProxies) > 0 { | ||
| policy, err := proxyproto.StrictWhiteListPolicy(impl.cfg.Api.ProxyProtocol.TrustedProxies) | ||
| if err != nil { | ||
| return fmt.Errorf("cannot create proxy protocol policy: %w", err) |
There was a problem hiding this comment.
P3: Missing span.RecordError(err) before returning the error. Other error returns in this function follow the pattern of recording the error to the span for tracing purposes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At pkg/probod/probod.go, line 586:
<comment>Missing `span.RecordError(err)` before returning the error. Other error returns in this function follow the pattern of recording the error to the span for tracing purposes.</comment>
<file context>
@@ -578,6 +580,22 @@ func (impl *Implm) runApiServer(
+ if len(impl.cfg.Api.ProxyProtocol.TrustedProxies) > 0 {
+ policy, err := proxyproto.StrictWhiteListPolicy(impl.cfg.Api.ProxyProtocol.TrustedProxies)
+ if err != nil {
+ return fmt.Errorf("cannot create proxy protocol policy: %w", err)
+ }
+
</file context>
Suggested change
| return fmt.Errorf("cannot create proxy protocol policy: %w", err) | |
| span.RecordError(err) | |
| return fmt.Errorf("cannot create proxy protocol policy: %w", err) |
Signed-off-by: Bryan Frimin <[email protected]>
gearnode
force-pushed
the
add-proxy-protocol-support
branch
from
56b8cd8 to
0bd2b11
Compare
Contributor
Author
|
@cubic-dev-ai please review |
@gearnode I have started the AI code review. It will take a few minutes to complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory in order to change the load balancer configuration and keep the the end-user IP address available on the request (required to e-signature, cookie consent, etc.).
I've use the most maintain library. I'm not a big fan of the code of the lib tbh if we got issue with it I will write our own implementation.