-
Notifications
You must be signed in to change notification settings - Fork 115
Fix task display #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task display #643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 18 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/helpers/src/date.ts">
<violation number="1" location="packages/helpers/src/date.ts:33">
P1: ISO 8601 duration parsing conflates Month and Minute. In ISO 8601, `M` means Month when before `T` (e.g., `P1M`) but Minute when after `T` (e.g., `PT1M`). The current regex `/PT?(\d+)([MDWH])/` makes `T` optional, so `P1M` (1 month) would incorrectly be formatted as "1 Minute".</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
979ff44 to
5ff31b3
Compare
gearnode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| ); | ||
| } | ||
|
|
||
| export function formatDuration(duration?: string | null, __?: (s: string) => string): string | null { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there are a lot of formatting options in the Intl JS API:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat
codenem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok if we do it like this for now for the duration but we should progressively migrate to the Intl and Temporal JS APIs
Signed-off-by: Sacha Al Himdani <[email protected]>
5ff31b3 to
6ab5ace
Compare
Summary by cubic
Improved task display to show description, owner, time estimate, and deadline. Simplified assignment by handling it through updateTask with assignedToId.
Bug Fixes
Migration
Written for commit 6ab5ace. Summary will update on new commits.