Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'linux/arm64' platforms #7094

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Add support for 'linux/arm64' platforms #7094

merged 3 commits into from
Aug 1, 2024

Conversation

lucydodo
Copy link
Member

@lucydodo lucydodo commented Aug 1, 2024

What type of PR is this?

  • Other

Description

When we take a snapshot, it also creates a Docker image for the ARM64 platform.

How is this tested?

  • Manually

Related Tickets & Documents

#5765

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Not applicable.

Notes

Currently, it takes about 3h to build a docker image.
Of course, I have a new ways in mind to improve this speed(cache, matrix, etc.). But PRs can get too complicated,
so I'm going to make changes to the core functionality first, and then improve the speed with additional PRs.

Any comments or review are welcome. Thank you.

@lucydodo lucydodo added the CI label Aug 1, 2024
@lucydodo lucydodo self-assigned this Aug 1, 2024
@lucydodo lucydodo mentioned this pull request Aug 1, 2024
@lucydodo
Copy link
Member Author

lucydodo commented Aug 1, 2024

This month's snapshot has already been created, so once this PR is approved and merged,
we can consider the new snapshot (24.08.1-dev)

@justinclift
Copy link
Member

This PR is a lot simpler than I was expecting for adding ARM64 support.

I kind of imagined it'd be some super complicated thing, so I'm glad it didn't need to be. 😄

@justinclift justinclift enabled auto-merge (squash) August 1, 2024 08:03
@lucydodo
Copy link
Member Author

lucydodo commented Aug 1, 2024

I created a PR that adds options to make it easier to create new snapshots: #7096
Perhaps that PR could be helpful for us as well.

@justinclift justinclift merged commit 8725fa4 into master Aug 1, 2024
14 checks passed
@lucydodo lucydodo deleted the feat/arm64 branch August 1, 2024 09:41
@zachliu
Copy link
Contributor

zachliu commented Aug 14, 2024

after adding .../poetry cache clear pypi --all, my gha build would spend hours on [stage-2 10/13] RUN /etc/poetry/bin/poetry install --only main,all_ds,dev --no-root --no-interaction --no-ansi and got random errors:

  • ModuleNotFoundError: No module named 'setuptools.command.install'
  • gcc: internal compiler error: Segmentation fault signal terminated program collect2
  • Error: The operation was canceled. (a timeout after 6 hours)

😿 😿 😿

@justinclift
Copy link
Member

What's a "gha"? 😄

@zachliu
Copy link
Contributor

zachliu commented Aug 14, 2024

github actions 😛

What's a "gha"? 😄

@zachliu
Copy link
Contributor

zachliu commented Aug 15, 2024

now i'm 90% sure that poetry cache clear... has nothing to do with my build issue 😅
the culprit is probably the setuptools version bump #7060

@justinclift
Copy link
Member

the culprit is probably the setuptools version bump #7060

Oh. Any idea what that version of setuptools breaks?

Bear in mind that one of the even newer versions of setuptools caused breakage and needed to be updated with a follow up point release: #7084

@zachliu
Copy link
Contributor

zachliu commented Aug 15, 2024

My gut tells me 70.0.0 is highly suspicious. The old 69.0.3 works. The newer 72.1.0 seems to work. I only tried one build using 72.1.0 though. It worked. I’ll do more builds tomorrow.

@zachliu
Copy link
Contributor

zachliu commented Aug 15, 2024

@justinclift my gut feeling was wrong, the culprit is poetry version mis-match #7122

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants