Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dependency-graph): Adding more context to the dependency graph #248

Merged

Conversation

IanWoodard
Copy link
Member

This change adds context about whether a given node in the dependency graph is a docker compose service (leaf) or a devservices service. This enables us to avoid cycles when we have docker compose services with the same name as the devservices service which is a common thing we see such as with snuba and it's container.
https://linear.app/getsentry/issue/DI-661/add-more-context-to-dependency-graph
This is required to enable the improvements we are looking to make to the status command: https://linear.app/getsentry/issue/DI-647/rework-status-command.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (73205dc) to head (6ea0534).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/dependencies.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   93.43%   93.51%   +0.08%     
==========================================
  Files          23       23              
  Lines        1675     1697      +22     
==========================================
+ Hits         1565     1587      +22     
  Misses        110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great tests 💯

@IanWoodard IanWoodard merged commit 0bb0075 into main Mar 31, 2025
14 checks passed
@IanWoodard IanWoodard deleted the ianwoodard/di-661-add-more-context-to-dependency-graph branch March 31, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants