-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(supervisor): Add tailing logs function #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 94.29% 94.32% +0.03%
==========================================
Files 24 24
Lines 1857 1886 +29
==========================================
+ Hits 1751 1779 +28
- Misses 106 107 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking solid as a whole. Left a few comments
Initially this was the fg command, but changed this since foregrounding a process is not reliable.
https://linear.app/getsentry/issue/DI-663/support-retrieving-logs-of-supervisor-processes