Skip to content

feat(supervisor): Add tailing logs function #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hubertdeng123
Copy link
Member

Initially this was the fg command, but changed this since foregrounding a process is not reliable.

https://linear.app/getsentry/issue/DI-663/support-retrieving-logs-of-supervisor-processes

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.32%. Comparing base (8223efd) to head (5ef5156).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/supervisor.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   94.29%   94.32%   +0.03%     
==========================================
  Files          24       24              
  Lines        1857     1886      +29     
==========================================
+ Hits         1751     1779      +28     
- Misses        106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid as a whole. Left a few comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants