feat(config): Add validation for non remote dependencies #274
+188
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 94.72% 94.88% +0.15%
==========================================
Files 27 27
Lines 2220 2249 +29
==========================================
+ Hits 2103 2134 +31
+ Misses 117 115 -2 ☔ View full report in Codecov by Sentry. |
IanWoodard
reviewed
May 14, 2025
IanWoodard
reviewed
May 15, 2025
| continue | ||
| except (ConfigParseError, ConfigValidationError): | ||
| console.warning(f"{repo} was found with an invalid config") | ||
| raise |
There was a problem hiding this comment.
Since we are now raising here, we should make sure the usages such as "list-services" handle this exception and exit with a non-zero status code and send it to sentry to avoid unhandled exceptions.
There was a problem hiding this comment.
done, the only direct command using this function is list-services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds safeguards to ensure that non-remote dependencies must have a docker compose service associated with them. It also fixes a bug where config validation fails, but the error is not raised properly
part of https://linear.app/getsentry/issue/DI-762/config-validation-for-dependencies