feat(config): Add supervisor programs dependency validation #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
commented
May 13, 2025
devservices/utils/dependencies.py
Outdated
| else DependencyType.COMPOSE, | ||
| dependency_type=( | ||
| DependencyType.SERVICE | ||
| if _has_remote_config(dependency.remote) |
There was a problem hiding this comment.
This is a pretty huge change, but seems safe to do given that the type is determined during the validation of config now
There was a problem hiding this comment.
To start out, if there are remote dependencies are in modes that include supervisor programs, they should be completely disabled. We don't want to support those workflows since a lot of the time it involves ensuring the venv is set up properly and the right directory is cd'd into
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## hubertdeng123/docker-compose-container-dependency-validation #275 +/- ##
================================================================================================
- Coverage 94.82% 94.78% -0.04%
================================================================================================
Files 27 27
Lines 2242 2245 +3
================================================================================================
+ Hits 2126 2128 +2
- Misses 116 117 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds safeguards to ensure that non-remote dependencies must have a docker compose service or supervisor program
part of https://linear.app/getsentry/issue/DI-762/config-validation-for-dependencies