Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tunneling/python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ Jinja2==3.0.1
MarkupSafe==2.0.1
requests==2.26.0
six==1.16.0
urllib3==1.26.7
urllib3==2.5.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The specified versions of requests (2.26.0) and urllib3 (2.5.0) are incompatible, which will cause a dependency resolution failure during installation.
  • Description: The requirements.txt file specifies requests==2.26.0 and urllib3==2.5.0. The requests library version 2.26.0 has a dependency requirement for urllib3<1.27. Because urllib3==2.5.0 violates this constraint, pip's dependency resolver will raise an error during installation. This will prevent the application's environment from being built and deployed. If these incompatible versions were somehow installed together, the application would crash at runtime with an AttributeError when making HTTP requests due to internal API changes in urllib3 v2.

  • Suggested fix: To resolve the dependency conflict, upgrade the requests package to a version that supports urllib3 v2, such as requests>=2.30.0. This will ensure compatibility and allow the dependencies to be installed correctly.
    severity: 0.9, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

Werkzeug==2.0.1