fix: Tokens only extend to the end of the line #131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Aug 8, 2025
This is the `sourcemapcache` equivalent of getsentry/rust-sourcemap#131 (but does not depend on it). Previously, when looking up a line and column, we would always return the token at or immediately before that position, even if it belonged to an earlier minified line. This is 1. wrong—tokens are only meant to extend to the end of a line. 2. inconsistent—this means that an unmapped line before any mapped line would return no mapping, but an unmapped line after a mapped line would.
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Aug 8, 2025
This is the `sourcemapcache` equivalent of getsentry/rust-sourcemap#131 (but does not depend on it). Previously, when looking up a line and column, we would always return the token at or immediately before that position, even if it belonged to an earlier minified line. This is 1. wrong—tokens are only meant to extend to the end of a line. 2. inconsistent—this means that an unmapped line before any mapped line would return no mapping, but an unmapped line after a mapped line would.
Previously, when looking up a line and column, we would always return the token at or immediately before that position, even if it belonged to an earlier minified line. This is 1. wrong—tokens are only meant to extend to the end of a line. 2. inconsistent—this means that an unmapped line before any mapped line would return no mapping, but an unmapped line after a mapped line would.
loewenheim
force-pushed
the
sebastian/token-line
branch
from
cf78d4b to
741f3f6
Compare
|
Actually, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when looking up a line and column, we would always return the token at or immediately before that position, even if it belonged to an earlier minified line. This is