Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ services:
build:
context: ./clickhouse
args:
BASE_IMAGE: "altinity/clickhouse-server:25.8.33.10002.altinitystable"
BASE_IMAGE: "clickhouse/clickhouse-server:26.8.36.3@sha256:d426d2f612e1e189c90f9a3f8dcd85a03c6851273833817a296bb327e63aa7a7"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClickHouse 26.8 needs AVX2

Medium Severity

Official clickhouse/clickhouse-server 26.6+ is built for x86-64-v3 and requires AVX2. The installer still only checks SSE4.2, which Altinity 25.8 accepted, so hosts that pass install can then crash ClickHouse with an illegal instruction after this bump.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d77d42f. Configure here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a problem (cc @aminvakil)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is a problem, do you want me to create a PR?

ulimits:
nofile:
soft: 262144
Expand Down
7 changes: 7 additions & 0 deletions install/upgrade-clickhouse.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ if $ps_command | grep -q clickhouse; then
echo "Upgrading clickhouse to 25.8"
$dcb $build_arg BASE_IMAGE=altinity/clickhouse-server:25.8.33.10002.altinitystable clickhouse
start_service_and_wait_ready clickhouse
elif [[ "$version" == "25.8.33.10002.altinitystable" ]]; then
echo "Detected clickhouse version $version"
$dc down clickhouse

echo "Upgrading clickhouse to 26.8"
$dcb $build_arg BASE_IMAGE=clickhouse/clickhouse-server:26.8.36.3 clickhouse
start_service_and_wait_ready clickhouse
else
echo "Detected clickhouse version $version. Skipping upgrades!"
fi
Expand Down
Loading