Skip to content

tests: change test coverage targets to Sentry and SentrySwiftUI #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+52 −1
Closed

tests: change test coverage targets to Sentry and SentrySwiftUI #4976

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2701e1a
tests: change test coverage targets to Sentry and SentrySwiftUI
philprime Mar 12, 2025
d1a8040
more coverage config
philprime Mar 13, 2025
313a275
ignore test files in slather
philprime Mar 13, 2025
aa66c1d
Update .slather.yml
philprime Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .slather.yml
View file
Original file line number Diff line number Diff line change
@@ -6,3 +6,6 @@ workspace: Sentry.xcworkspace
scheme: Sentry
source_directory: Sources
output_directory: slather
ignore:
- '**/Tests/**'
- '**/SentryTestUtils/**'
14 changes: 14 additions & 0 deletions Plans/SentrySwiftUI_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,20 @@
}
],
"defaultOptions" : {
"codeCoverage" : {
"targets" : [
{
"containerPath" : "container:Sentry.xcodeproj",
"identifier" : "D8199DA929376E9B0074249E",
"name" : "SentrySwiftUI"
},
{
"containerPath" : "container:Sentry.xcodeproj",
"identifier" : "63AA759A1EB8AEF500D153DE",
"name" : "Sentry"
}
]
},
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
15 changes: 14 additions & 1 deletion Plans/SentryTests_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,20 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"codeCoverage" : {
"targets" : [
{
"containerPath" : "container:Sentry.xcodeproj",
"identifier" : "63AA759A1EB8AEF500D153DE",
"name" : "Sentry"
},
{
"containerPath" : "container:Sentry.xcodeproj",
"identifier" : "D8199DA929376E9B0074249E",
"name" : "SentrySwiftUI"
}
]
},
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
14 changes: 14 additions & 0 deletions Plans/Sentry_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,20 @@
}
],
"defaultOptions" : {
"codeCoverage" : {
"targets" : [
{
"containerPath" : "container:Sentry.xcodeproj",
"identifier" : "63AA759A1EB8AEF500D153DE",
"name" : "Sentry"
},
{
"containerPath" : "container:Sentry.xcodeproj",
"identifier" : "D8199DA929376E9B0074249E",
"name" : "SentrySwiftUI"
}
]
},
"environmentVariableEntries" : [
{
"key" : "TSAN_OPTIONS",
1 change: 1 addition & 0 deletions Plans/SwiftUITestSample_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
1 change: 1 addition & 0 deletions Plans/iOS-ObjectiveC_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
1 change: 1 addition & 0 deletions Plans/iOS-Swift6_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
1 change: 1 addition & 0 deletions Plans/iOS-Swift_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"commandLineArgumentEntries" : [
{
"argument" : "--io.sentry.disable-everything",
1 change: 1 addition & 0 deletions Plans/iOS15-SwiftUI.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
1 change: 1 addition & 0 deletions Plans/macOS-SwiftUI_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
1 change: 1 addition & 0 deletions Plans/visionOS-Swift_Base.xctestplan
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [

Unchanged files with check annotations Beta

View file
Tests/SentryTests/Integrations/SessionReplay/SentryTouchTrackerTests.swift
#if os(iOS)

Check failure on line 1 in Tests/SentryTests/Integrations/SessionReplay/SentryTouchTrackerTests.swift

GitHub Actions / JUnit Test Report

SentryTouchTrackerTests.testLock 

/Users/runner/work/sentry-cocoa/sentry-cocoa/Tests/SentryTests/Integrations/SessionReplay/SentryTouchTrackerTests.swift:334 - Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "read".
@testable import Sentry
import SentryTestUtils
readExp.fulfill()
}
wait(for: [addExp, removeExp, readExp], timeout: 1)

Check failure on line 334 in Tests/SentryTests/Integrations/SessionReplay/SentryTouchTrackerTests.swift

GitHub Actions / Unit iOS - Xcode 15.4 - OS 17.2 Sentry 

    testLock, Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "read".
}
}
#endif