Skip to content

ci: ios swift xcodegen cleanup #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: armcknight/ci/ios13-swift-xcodegen
Choose a base branch
from

Conversation

armcknight
Copy link
Member

now that the original tracked iOS-Swift.xcodeproj is gone, we don't need to disambiguate the other projects with a _xcodeproj suffix (really was only necessary for the new xcodegen-managed iOS-Swift xcode project but i used it for all of them anyways) and move the iOS-Swift sources one level up from //Samples/iOS-Swift/iOS-Swift to //Samples/iOS-Swift.

Follows the xcodegen work after #5117

#skip-changelog

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.775%. Comparing base (297e221) to head (561314c).

Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                          @@
##           armcknight/ci/ios13-swift-xcodegen     #5118   +/-   ##
====================================================================
  Coverage                              92.775%   92.775%           
====================================================================
  Files                                     677       677           
  Lines                                   84281     84271   -10     
  Branches                                30669     30654   -15     
====================================================================
- Hits                                    78192     78183    -9     
+ Misses                                   5987      5984    -3     
- Partials                                  102       104    +2     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297e221...561314c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 22, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.88 ms 1239.85 ms 15.98 ms
Size 22.31 KiB 851.56 KiB 829.26 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant