-
-
Notifications
You must be signed in to change notification settings - Fork 349
ci: ios swift xcodegen cleanup #5118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
armcknight
wants to merge
27
commits into
armcknight/ci/ios13-swift-xcodegen
Choose a base branch
from
armcknight/ci/ios-swift-cleanup
base: armcknight/ci/ios13-swift-xcodegen
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ci: ios swift xcodegen cleanup #5118
armcknight
wants to merge
27
commits into
armcknight/ci/ios13-swift-xcodegen
from
armcknight/ci/ios-swift-cleanup
+350
−358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vel down" This reverts commit cd64d82.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## armcknight/ci/ios13-swift-xcodegen #5118 +/- ##
====================================================================
Coverage 92.775% 92.775%
====================================================================
Files 677 677
Lines 84281 84271 -10
Branches 30669 30654 -15
====================================================================
- Hits 78192 78183 -9
+ Misses 5987 5984 -3
- Partials 102 104 +2 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
…ios-swift-cleanup
…ios-swift-cleanup
…new directory under Samples/
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
…ios-swift-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that the original tracked iOS-Swift.xcodeproj is gone, we don't need to disambiguate the other projects with a _xcodeproj suffix (really was only necessary for the new xcodegen-managed iOS-Swift xcode project but i used it for all of them anyways) and move the iOS-Swift sources one level up from //Samples/iOS-Swift/iOS-Swift to //Samples/iOS-Swift.
Follows the xcodegen work after #5117
#skip-changelog