Skip to content

meta: correct version setting #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: armcknight/ci/ios-swift-cleanup
Choose a base branch
from

Conversation

armcknight
Copy link
Member

I noticed something about how we version some things while going through the XcodeGen refactor: we were setting CURRENT_PROJECT_VERSION = 8.49.1 for the SentrySDK and SentrySwiftUI framework products. However, that setting is supposed to only be an integer value. The semantic version is supposed to go into MARKETING_VERSION.

We also had a couple disparate places where we would write the semver. So, this unifies them all into a single source of truth, and uses the correct build settings.

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- correct version setting ([#5139](https://github.com/getsentry/sentry-cocoa/pull/5139))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 37b6f13

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (armcknight/ci/ios-swift-cleanup@b0e86e0). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                         @@
##             armcknight/ci/ios-swift-cleanup     #5139   +/-   ##
===================================================================
  Coverage                                   ?   92.780%           
===================================================================
  Files                                      ?       677           
  Lines                                      ?     84271           
  Branches                                   ?     30651           
===================================================================
  Hits                                       ?     78187           
  Misses                                     ?      5983           
  Partials                                   ?       101           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e86e0...37b6f13. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.20 ms 1247.38 ms 27.18 ms
Size 22.31 KiB 851.56 KiB 829.25 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant