-
-
Notifications
You must be signed in to change notification settings - Fork 349
meta: correct version setting #5139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: armcknight/ci/ios-swift-cleanup
Are you sure you want to change the base?
meta: correct version setting #5139
Conversation
…a/correct-version-setting
…a/correct-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- correct version setting ([#5139](https://github.com/getsentry/sentry-cocoa/pull/5139)) If none of the above apply, you can opt out of this check by adding |
…orrect-version-setting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## armcknight/ci/ios-swift-cleanup #5139 +/- ##
===================================================================
Coverage ? 92.780%
===================================================================
Files ? 677
Lines ? 84271
Branches ? 30651
===================================================================
Hits ? 78187
Misses ? 5983
Partials ? 101 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
…orrect-version-setting
I noticed something about how we version some things while going through the XcodeGen refactor: we were setting
CURRENT_PROJECT_VERSION = 8.49.1
for the SentrySDK and SentrySwiftUI framework products. However, that setting is supposed to only be an integer value. The semantic version is supposed to go into MARKETING_VERSION.We also had a couple disparate places where we would write the semver. So, this unifies them all into a single source of truth, and uses the correct build settings.