Skip to content

test: shared sdk lib #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 382 commits into from
May 13, 2025
Merged

test: shared sdk lib #5181

merged 382 commits into from
May 13, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented May 6, 2025

Take 2 of sharing SentrySDKWrapper. Finally getting back to it after moving the sample app projects to xcodegen to solve the issues hit in #5077 and #5085

#skip-changelog

Copy link
Contributor

github-actions bot commented May 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.78 ms 1254.17 ms 19.39 ms
Size 23.76 KiB 862.54 KiB 838.78 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1ee5a37 1209.37 ms 1222.04 ms 12.68 ms
7f691b5 1233.94 ms 1243.80 ms 9.86 ms
e070f8a 1236.47 ms 1250.50 ms 14.03 ms
c8dbe73 1215.37 ms 1237.31 ms 21.94 ms
aeec206 1229.27 ms 1253.70 ms 24.43 ms
c810e58 1221.57 ms 1250.45 ms 28.88 ms
034be1c 1222.67 ms 1236.22 ms 13.55 ms
533859f 1237.78 ms 1249.76 ms 11.98 ms
4977fbc 1231.55 ms 1239.80 ms 8.25 ms
742d4b6 1204.00 ms 1217.90 ms 13.90 ms

App size

Revision Plain With Sentry Diff
1ee5a37 21.58 KiB 670.39 KiB 648.81 KiB
7f691b5 20.76 KiB 420.55 KiB 399.79 KiB
e070f8a 21.58 KiB 546.20 KiB 524.62 KiB
c8dbe73 21.58 KiB 615.91 KiB 594.33 KiB
aeec206 20.76 KiB 434.88 KiB 414.12 KiB
c810e58 22.32 KiB 761.10 KiB 738.78 KiB
034be1c 20.76 KiB 436.66 KiB 415.90 KiB
533859f 22.85 KiB 408.84 KiB 386.00 KiB
4977fbc 20.76 KiB 419.86 KiB 399.10 KiB
742d4b6 21.58 KiB 546.20 KiB 524.61 KiB

Previous results on branch: armcknight/test/shared-sdk-lib

Startup times

Revision Plain With Sentry Diff
70f52e4 1210.31 ms 1231.76 ms 21.45 ms
4d8903b 1214.24 ms 1236.22 ms 21.98 ms

App size

Revision Plain With Sentry Diff
70f52e4 23.76 KiB 861.22 KiB 837.46 KiB
4d8903b 23.76 KiB 861.22 KiB 837.46 KiB

Base automatically changed from armcknight/ci/watchos-swift-xcodegen to main May 7, 2025 16:43
@armcknight armcknight changed the base branch from main to armcknight/test/clean-up-xcconfigs May 7, 2025 22:08
@armcknight armcknight marked this pull request as ready for review May 7, 2025 22:08
@armcknight
Copy link
Member Author

armcknight commented May 8, 2025

I'm investigating what's up with benchmarking tests all failing in this PR. They pass in subsequent PRs that build on top of this one so I'm skeptical it's a legit failure. Rerunning them but heading to sleep so will have a look at the result in the morning.

Base automatically changed from armcknight/test/clean-up-xcconfigs to main May 8, 2025 23:06
@armcknight
Copy link
Member Author

Benchmarking seems to have all passed after a rerun ¯\(ツ)

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@armcknight armcknight merged commit 1b8f773 into main May 13, 2025
53 of 54 checks passed
@armcknight armcknight deleted the armcknight/test/shared-sdk-lib branch May 13, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants