-
-
Notifications
You must be signed in to change notification settings - Fork 361
test: shared sdk lib #5181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: shared sdk lib #5181
Conversation
…os13-swift-xcodegen
…orrect-version-setting
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…ght/ci/ios-swift-xcodegen
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…i/macos-swift-xcodegen
…ios-objectivec-xcodegen
…ci/tvos-swift-xcodegen
…atchos-swift-xcodegen
…est/shared-sdk-lib
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1ee5a37 | 1209.37 ms | 1222.04 ms | 12.68 ms |
7f691b5 | 1233.94 ms | 1243.80 ms | 9.86 ms |
e070f8a | 1236.47 ms | 1250.50 ms | 14.03 ms |
c8dbe73 | 1215.37 ms | 1237.31 ms | 21.94 ms |
aeec206 | 1229.27 ms | 1253.70 ms | 24.43 ms |
c810e58 | 1221.57 ms | 1250.45 ms | 28.88 ms |
034be1c | 1222.67 ms | 1236.22 ms | 13.55 ms |
533859f | 1237.78 ms | 1249.76 ms | 11.98 ms |
4977fbc | 1231.55 ms | 1239.80 ms | 8.25 ms |
742d4b6 | 1204.00 ms | 1217.90 ms | 13.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1ee5a37 | 21.58 KiB | 670.39 KiB | 648.81 KiB |
7f691b5 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
e070f8a | 21.58 KiB | 546.20 KiB | 524.62 KiB |
c8dbe73 | 21.58 KiB | 615.91 KiB | 594.33 KiB |
aeec206 | 20.76 KiB | 434.88 KiB | 414.12 KiB |
c810e58 | 22.32 KiB | 761.10 KiB | 738.78 KiB |
034be1c | 20.76 KiB | 436.66 KiB | 415.90 KiB |
533859f | 22.85 KiB | 408.84 KiB | 386.00 KiB |
4977fbc | 20.76 KiB | 419.86 KiB | 399.10 KiB |
742d4b6 | 21.58 KiB | 546.20 KiB | 524.61 KiB |
Previous results on branch: armcknight/test/shared-sdk-lib
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70f52e4 | 1210.31 ms | 1231.76 ms | 21.45 ms |
4d8903b | 1214.24 ms | 1236.22 ms | 21.98 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70f52e4 | 23.76 KiB | 861.22 KiB | 837.46 KiB |
4d8903b | 23.76 KiB | 861.22 KiB | 837.46 KiB |
I'm investigating what's up with benchmarking tests all failing in this PR. They pass in subsequent PRs that build on top of this one so I'm skeptical it's a legit failure. Rerunning them but heading to sleep so will have a look at the result in the morning. |
Benchmarking seems to have all passed after a rerun ¯\(ツ)/¯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Take 2 of sharing SentrySDKWrapper. Finally getting back to it after moving the sample app projects to xcodegen to solve the issues hit in #5077 and #5085
#skip-changelog